Re: [PATCH] fs/Kconfig: more consistent configuration of XFS
Date: Thu Apr 28 2005 - 03:55:38 EST
On 4/28/05, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Thu, Apr 28, 2005 at 04:55:48PM +0900, aq wrote:
> > hello,
> > At the moment, the configuration interface of Filesystem is not very consistent:
> > - All other filesystem configurations (like Reiserfs, JFS, ext3,...)
> > is in fs/Kconfig, but only XFS is in a separate file fs/xfs/Kconfig
> > - All other filesystem configuration is processed in the same screen
> > (using a kind of drop-down interface), but XFS configuration is done
> > in a separate screen.
> > Here is the patch to fix the problem: it moves XFS configuration from
> > fs/xfs/Kconfig to fs/Kconfig, makes it to do all the configuration in
> > the same screen (by removing "menu" directive), and removes the
> > unnecessary fs/xfs/Kconfig.
> The screen bits is fine, btu please keep fs/xfs/Kconfig. It make maintaince
> a lot a easier for us XFS people.
I dont see why we should keep a file in kernel tree without using it
(since the patch removes "source xfs/Kconfig). Anyway, here is another
patch that doesnt remove fs/xfs/Kconfig.
Also note that this patch (and the last one, too) moves "config
XFS_EXPOR" to the bottom, so the menu intems aligns better and
consistently with others (like what Reiserfs, JFS,... are doing)
Andrew, please pick one of these two. Thank you.
# diffstat makefile.fs2.patch
Kconfig | 82 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
1 files changed, 81 insertions(+), 1 deletion(-)
Signed-off-by: Nguyen Anh Quynh <aquynh@xxxxxxxxx>\
Description: Binary data