From: Pete Zaitcev
Date: Sun Jun 27 2004 - 18:58:05 EST
On Sun, 27 Jun 2004 00:46:53 +0200
Oliver Neukum <oliver@xxxxxxxxxx> wrote:
> > + /* XXX Can be done at init */
> > + scmd->cdb = REQUEST_SENSE;
> > + scmd->cdb_len = 6;
> > + scmd->dir = UB_DIR_READ;
> > + scmd->state = UB_CMDST_INIT;
> > + scmd->data = sc->top_sense;
> You must allocate a separate buffer to the sense data.
> We had similar code in hid which leads to data corruption
> on some architectures. It's an issue of DMA coherency.
I agree. This is also an issue for the work_bcs. I postponed doing it
right because that area waits for changes regarding queueing and
error processing in such case.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/