Re: [3C509] Fix sysfs leak.
From: Dave Jones
Date: Tue Mar 16 2004 - 09:53:58 EST
On Tue, Mar 16, 2004 at 03:09:49PM +0100, Marc Zyngier wrote:
> >>>>> "Dave" == Dave Jones <davej@xxxxxxxxxx> writes:
> Dave> Then the probing routine is bogus, it returns 0 when it fails too.
> Uh ? el3_eisa_probe looks like it properly returns an error...
> Or maybe you call a failure not finding a proper device on the bus ?
The damned bus doesn't even exist. If this is a case that couldn't be
detected, I'd not be complaining, but this is just nonsense having
a driver claim that its found an EISA device, when there aren't even
any EISA slots on the board.
> When the driver registers, the bus may not have been probed yet
> (built-in case). So un-registering the driver when it fails to find a
> proper device is simply wrong with the current implementation.
This happens long after bus initialisation should have already figured
out that the bus doesn't exist. Even if it was left this late, the
eisa registration code should be doing a 'oh, I've not even checked
if I have a bus yet, I'll do it now' before it starts doing completely
bogus things like checking for devices.
The way I see it, EISA bus support is completely horked right now.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/