Re: ->direct_IO API change in current 2.4 BK

From: Trond Myklebust (trond.myklebust@fys.uio.no)
Date: Wed Jul 09 2003 - 13:50:59 EST


>>>>> " " == Marc-Christian Petersen <m.c.p@wolk-project.de> writes:

> err, -aa has XFS per default, -wolk has XFS per default. So
> ... ;)

So they have both XFS + NFS O_DIRECT?

The answer to your question is then that somebody made the trivial
conversion on XFS... It's just a question of replacing the second
argument of the direct_IO() method with a filp, then extracting the
inode from that. A 2-liner patch at most...

The point here is that Marcelo's tree does not include XFS, so my
patch can't fix it up...
As I said, I suggest replacing KERNEL_HAS_O_DIRECT with
KERNEL_HAS_O_DIRECT2 so that the XFS patches can switch on that, and
hence provide the 2-liner on newer kernels...

Cheers,
  Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jul 15 2003 - 22:00:32 EST