Re: [PATCH] Trivial request_region check patchset.

• Next message: Michal Jaegermann: "max partition size"
• Previous message: Cameron Simpson: "Re: debugging eth driver"
• In reply to: Rusty Russell: "[PATCH] Trivial request_region check patchset."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Mar 22, 2002 17:13 +1100, Rusty Russell wrote:
> Evgeniy Polyakov <johnpol@2ka.mipt.ru> has been working his
> way through the kernel, auditing request_region calls (which as of 2.4
> return an int). Please peruse for your drivers before I send them all
> to Linus, and watch out for more mails from Evgeniy!

Thank you Evgeniy for this work. A very minor change request - please
follow the kernel CodingStyle:

        if (!request_region(0xa0, 0x20, "pic2"))
                {
                release_region(0x20, 0x20);
                return;
                }

should be:

        if (!request_region(0xa0, 0x20, "pic2")) {
                release_region(0x20, 0x20);
                return;
        }

Cheers, Andreas

--
Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
                 \  would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Michal Jaegermann: "max partition size"
• Previous message: Cameron Simpson: "Re: debugging eth driver"
• In reply to: Rusty Russell: "[PATCH] Trivial request_region check patchset."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Mar 23 2002 - 22:00:27 EST