> @@ -2929,7 +2928,6 @@
> capacity: ide_cdrom_capacity,
> special: NULL,
> proc: NULL,
> - driver_init: ide_cdrom_init,
> driver_reinit: ide_cdrom_reinit,
> };
>
> @@ -2967,7 +2965,7 @@
> DRIVER(drive)->busy--;
> failed--;
>
> - ide_register_module(&ide_cdrom_driver);
> + revalidate_drives();
> MOD_DEC_USE_COUNT;
> return 0;
> }
hum, I'm not sure that removing ->driver_init is a good idea.
Seems like a loss of flexibility to me, not a cleanup, and I wonder if
you have thought through all the paths that wind up calling
->driver_init.
Jeff
-- Jeff Garzik | "Why is it that attractive girls like you Building 1024 | always seem to have a boyfriend?" MandrakeSoft | "Because I'm a nympho that owns a brewery?" | - BBC TV show "Coupling" - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Feb 23 2002 - 21:00:31 EST