On Thu, Oct 19, 2000 at 07:18:49PM +1100, Keith Owens wrote:
> See conclusion, jump to conclusion :(. There was a missing line from
> the boilerplate conversion of lists to old style Makefile variables.
> Forget my previous patch, use this one. Against 2.4.0-test10-pre4.
> Index: 0-test10-pre4.1/drivers/usb/Makefile
> --- 0-test10-pre4.1/drivers/usb/Makefile Mon, 02 Oct 2000 15:28:44 +1100 kaos (linux-2.4/n/b/19_Makefile 188.8.131.52 644)
> +++ 0-test10-pre4.1(w)/drivers/usb/Makefile Thu, 19 Oct 2000 19:05:04 +1100 kaos (linux-2.4/n/b/19_Makefile 184.108.40.206 644)
> @@ -99,6 +99,10 @@
> obj-m := $(filter-out $(obj-y), $(obj-m))
> int-m := $(filter-out $(int-y), $(int-m))
> +# Take multi-part drivers out of obj-y and put components in.
> +obj-y := $(filter-out $(list-multi), $(obj-y)) $(int-y)
> # Translate to Rules.make lists.
> O_OBJS := $(filter-out $(export-objs), $(obj-y))
Eeek! No, I took that out back in test9-pre7 to solve the ordering
problem that we were having (the hub driver's __init function in the
usbcore.o needed to be called _before_ the other driver's __init
functions when everything is compiled into the kernel statically,
otherwise we get a whole lot of kernel log spam on startup, see the
exchange on the KBUILD list for more details.)
Bleah, if we had the LINK_FIRST stuff in, then this rule could go back
and fix the problem. Although I agree that not being able to compile at
all is _much_ worse than having to put up with a bunch of messages at
-- greg@(kroah|wirex).com http://immunix.org/~greg - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to firstname.lastname@example.org Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Oct 23 2000 - 21:00:15 EST